feat: #3001 add Modal sandbox idle timeout option#3005
Merged
Conversation
github-actions
Bot
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds
idle_timeoutsupport toModalSandboxClientOptionsso Modal-backed sandbox sessions can configure Modal's inactivity shutdown window separately from the overall sandbox lifetime.The change persists
idle_timeoutinModalSandboxSessionState, passes it through to fresh Modal sandbox creation and snapshot filesystem restore creation, and preserves backwards-compatible deserialization for older state payloads where the field is absent. The new option is appended to the public constructor order to avoid changing existing positional argument meaning.This pull request resolves #3001.